Skip to content

Conversation

tadjik1
Copy link
Member

@tadjik1 tadjik1 commented Sep 24, 2025

Description

Summary of Changes

This PR migrates the integration tests for gridfs. The changes include:

  • Big refactoring for stream tests (removing duplicates, using async/await, and modern Node.js utilities to work with streams)
  • Import directly from the src folder, convert .js into .ts
Notes for Reviewers

To simplify the review process, this PR is split into several commits:

  • Several commits only contain small changes (up to 8 lines) with either types or imports or linter fixes
  • The biggest commit contains all the refactoring, I put extra effort to avoid structural changes (I hope it will still be possible to compare changes line by line or at least block by block). Please let me know if you would want me to split this commit into smaller chunks.

Those tests are quite old, some of them test callbacks and promises API separately, that's why I have removed a few.

What is the motivation for this change?

This work is part of a larger, ongoing initiative to convert all tests to use async/await, with the ultimate goal of removing the legacy driver wrapper.

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 changed the title test(NODE-7183): import from src test(NODE-7183): migrate integration/gridfs tests Sep 24, 2025
@tadjik1 tadjik1 marked this pull request as ready for review September 24, 2025 14:49
@tadjik1 tadjik1 requested a review from a team as a code owner September 24, 2025 14:49
@tadjik1 tadjik1 marked this pull request as draft September 24, 2025 15:46
@tadjik1 tadjik1 marked this pull request as ready for review September 24, 2025 16:07
@baileympearson baileympearson self-assigned this Sep 25, 2025
@baileympearson baileympearson added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Sep 25, 2025
@baileympearson baileympearson merged commit 4740acf into main Sep 25, 2025
24 of 27 checks passed
@baileympearson baileympearson deleted the NODE-7183 branch September 25, 2025 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants